Deleting the actual content of a post (and its subject) while "! Delete this message !" is checked, then submitting will also return an error. If that particular option is checked we should probably just ignore the contents of the message/subject input. ()

(You can probably just spam empty BBCode tags to get around any kind of word/character limit, so please, bear that in mind if implementing any such checks. The return key shouldn't count towards the minimum, either.)

Sounds like there is a minor bug in the delete post option.

Using the 'delete message' option on the first post in the thread comes up "thank you, your post has been edited" lol.

Either way, not sure if it even works, but I did make an attempt to rearrange the logic that handles this functionality to get it to actually... yeah. See PR

https://bugs.xmbforum2.com/view.php?id=943

This is the delete issue.

https://bugs.xmbforum2.com/view.php?id=944

This is the text issue.

Regarding the PR, we don't commit untested code here so I'm not sure what is the expectation for an untested PR.

Disallowing users from deleting their own posts is not the direction I want to take for resolving the text change issue.

Quote: Originally posted by miqrogroove

Disallowing users from deleting their own posts is not the direction I want to take for resolving the text change issue.

You already can't delete the first post in a thread, even if there's no other posts. Pretty sure you were able to at one point. Just kind of assumed it was changed to prevent some havoc

Also, unrelated but:

https://github.com/marketplace/actions/composer-php-actions

Could be useful, for what it's worth.

I agree it's broken for empty forms, but it does allow deleting the first post in a thread otherwise. If you've found more bugs theb we can keep adding them.

https://forums.xmbforum2.com/post.php?action=edit&fid=32...

I'm trying to delete this very post, and I can't. It just says 'thank you for editing your post' even when I click the delete button.

The previous behaviour was that it would remove the thread if there were no replies.

Something might be broken here:

https://github.com/miqrogroove/xmb/blob/cda11cb9c2e1aff9de42...

This restricts post deletion to moderators only. I'll take a deeper look tonight to figure out what happened. Maybe something I broke for 1.10.

Yeah I can see why that happened. The old code was terrible for readability:

Code:

if ( $status1 != 'Moderator' && ( $self['username'] !== $orig['author'] || $thread['closed'] != '' ) ) {

I'm going to rewrite that logic without the triple negative:

Code:

$canEdit = $isMod || $vars->self['username'] === $orig['author'] && $thread['closed'] == '';

I'm caught up on bugs now. There were some changes to the upgrade script that I'll have to test more before it can be packaged.