XMB Forum Software
Not logged in [Login - Register]
Go To Bottom

Printable Version  
 Pages:  1  2  
Author:

[New] XMB 1.9.12.4.BETA

Scarlet
Member
***




Posts: 60
Registered: 9-15-2017
Location: England
Member Is Offline

Mood: Excited for XMB's resurrection!

[*] posted on 9-20-2017 at 06:38 AM


Yes! I bet you so! :3

I removed the word BETA from the version string and left the BETA that was in the $beta string, so it isn't duplicated anymore. :)

Anyway feel free to push the installer stuff and make some changes to detect PHP 5.5 or later and auto-select mysqli... Then I think we can call it a proper release since nothing has broken on my end so far. :P
View user's profile View All Posts By User This user has MSN Messenger
Jenny Lee
Member
***




Posts: 35
Registered: 7-21-2017
Location: England, UK
Member Is Offline

Mood: Meh. :P

[*] posted on 9-20-2017 at 08:34 AM


Two more things to get fixed:

  1. Wrong offset while rendering polls(shows only first letter of every option)
  2. Wrong number formatting in stats page(works,but throws ugly warnings)

offset.PNG - 33kBformat.PNG - 12kB

P.S. Tested in PHP version 7.1.9 & 7.1.8
View user's profile View All Posts By User
Scarlet
Member
***




Posts: 60
Registered: 9-15-2017
Location: England
Member Is Offline

Mood: Excited for XMB's resurrection!

[*] posted on 9-20-2017 at 10:11 AM


Not getting the poll error on 7.0, although you're using 7.1 so uh... yeah, we need to fix that I guess.
View user's profile View All Posts By User This user has MSN Messenger
Jenny Lee
Member
***




Posts: 35
Registered: 7-21-2017
Location: England, UK
Member Is Offline

Mood: Meh. :P

[*] posted on 9-20-2017 at 03:22 PM


Quote: Originally posted by Scarlet  
Not getting the poll error on 7.0, although you're using 7.1 so uh... yeah, we need to fix that I guess.


Indeed. Just tested using 7.0.23, works bugless. I think they might have changed something with 7.1.x branch.
View user's profile View All Posts By User
Scarlet
Member
***




Posts: 60
Registered: 9-15-2017
Location: England
Member Is Offline

Mood: Excited for XMB's resurrection!

[*] posted on 9-20-2017 at 03:39 PM


Yeah, best to be safe and make sure everything is compatible though. I probably won't adopt PHP 7.1 until it becomes a bit more mature, and once XMB is patched to work with it.

Have you looked into the problem so far?
View user's profile View All Posts By User This user has MSN Messenger
Jenny Lee
Member
***




Posts: 35
Registered: 7-21-2017
Location: England, UK
Member Is Offline

Mood: Meh. :P

[*] posted on 9-20-2017 at 04:11 PM


Quote: Originally posted by Scarlet  
Yeah, best to be safe and make sure everything is compatible though. I probably won't adopt PHP 7.1 until it becomes a bit more mature, and once XMB is patched to work with it.

Have you looked into the problem so far?


Not yet, I was busy with daily chores and other stuff.
In regards of PHP 7.1.x, it's stable enough, because it's not some beta release or anything. It most likely has some sort of adjustment on how offsets are being handled, most likely it requires a different syntax in order to make it function properly.

I can probably fix it for myself, I just let the forum know that there's an issue that could be stumbled upon.:)

I'm in preparation of fully porting XMB to MySQLi(prepared statements) while at the same time getting rid of old MySQL(supporting both is not an option for me). Cause why have two things that serves the same purpose and especially when one of them is ****tier at doing it? XMB always meant to be lightweight, hehehehe:lol:
View user's profile View All Posts By User
Scarlet
Member
***




Posts: 60
Registered: 9-15-2017
Location: England
Member Is Offline

Mood: Excited for XMB's resurrection!

[*] posted on 9-20-2017 at 04:29 PM


Ah, alright.

I'll consider upgrading to PHP 7.1 when the XMB bugs are ironed out and it has been made compatible. But yeah, it probably does, hence why that.

And yeah, hopefully someone can see this and respond to this so you don't have to do the hard work ;)

As for XMB to MySQLi, I agree. XMB is supposed to be a lightweight solution, so why keep the deprecated/removed system? :P
View user's profile View All Posts By User This user has MSN Messenger
Jenny Lee
Member
***




Posts: 35
Registered: 7-21-2017
Location: England, UK
Member Is Offline

Mood: Meh. :P

[*] posted on 9-20-2017 at 05:55 PM


I did further testing. If the poll already has your vote and tries to display the result, it completely blows up the whole script ending it with fatal error.eeee.PNG - 5kB

This is the reason for it:
As of PHP 7.1.0, applying the empty index operator on a string throws a fatal error. Formerly, the string was silently converted to an array.(PHP Notes)


Prior to PHP 7.1 this was valid:
Code:
$str = 'hello'; $str[] = 'good-bye'; //returns an array with two elements ['hello', 'good-bye'];


But PHP 7.1 would just return an error: Uncaught Error: [] operator not supported for strings, which is exact response I'm getting.

Code:
<?php $hellomsg='Hey there!!!'; $str=''; $str['hello'] = $hellomsg; var_dump($str['hello']); Response: Warning: Illegal string offset 'hello' in C:\UwAmp\www\3\test.php on line 7 Warning: Illegal string offset 'hello' in C:\UwAmp\www\3\test.php on line 10 string(1) "H"


As you may see it also returns the first letter of the string $str['hello'], just like the poll options in XMB. I'm 100% positive that that's the problem we encountering in here.

Fix for both examples(cast first occurrence that is defined as string to an array):
Code:
$str = (array)$str; // lets cast a string to an array


Now it's really up to just finding which lines & strings to tune up in XMB:lol:



View user's profile View All Posts By User
Scarlet
Member
***




Posts: 60
Registered: 9-15-2017
Location: England
Member Is Offline

Mood: Excited for XMB's resurrection!

[*] posted on 9-21-2017 at 06:08 AM


Thanks for looking into the problem. What pages are affected by this?
View user's profile View All Posts By User This user has MSN Messenger
Jenny Lee
Member
***




Posts: 35
Registered: 7-21-2017
Location: England, UK
Member Is Offline

Mood: Meh. :P

[*] posted on 9-21-2017 at 08:16 AM


Quote: Originally posted by Scarlet  
Thanks for looking into the problem. What pages are affected by this?


It's all in the screenshots I've attached, but since you asked: viewthread.php(compatibility issues mentioned in my last post) & stats.php(formatting errors)

Either way, I have already patched those mentioned files & everything runs smoothly on 7.1.x(so far). :yes::singing:
View user's profile View All Posts By User
Scarlet
Member
***




Posts: 60
Registered: 9-15-2017
Location: England
Member Is Offline

Mood: Excited for XMB's resurrection!

[*] posted on 9-21-2017 at 11:25 AM


Thank you for helping.
Hopefully Xian will see this and add it to 1.9.12.5, although I haven't seen him here since the 19th... I'm hoping he's okay :)
View user's profile View All Posts By User This user has MSN Messenger
Jenny Lee
Member
***




Posts: 35
Registered: 7-21-2017
Location: England, UK
Member Is Offline

Mood: Meh. :P

[*] posted on 9-21-2017 at 04:00 PM


Quote: Originally posted by Scarlet  
Thank you for helping.
Hopefully Xian will see this and add it to 1.9.12.5, although I haven't seen him here since the 19th... I'm hoping he's okay :)


Yeah, that 's quite normal. People are being busy with life and so on.:smilegrin: Btw, he's not the only one that can access and upload changes to Sourceforge, so his absence not big of the deal.
View user's profile View All Posts By User
lottos
Administrator
********




Posts: 357
Registered: 6-3-2002
Location: Competitions Australia: https://www.lottos.com.au/
Member Is Offline

Mood: pass me a TimTam

[*] posted on 9-21-2017 at 09:07 PM


Quote: Originally posted by Jenny Lee  
Btw, he's not the only one that can access and upload changes to Sourceforge, so his absence not big of the deal.


I've put the issue into the bugtracker, thanks.




Largest list of competitions online!
View user's profile Visit user's homepage View All Posts By User
Scarlet
Member
***




Posts: 60
Registered: 9-15-2017
Location: England
Member Is Offline

Mood: Excited for XMB's resurrection!

[*] posted on 9-22-2017 at 06:26 AM


How would I go about committing to the repository? I don't know SourceForge too well, only GitHub.
View user's profile View All Posts By User This user has MSN Messenger
Xian
Member
***


Avatar


Posts: 47
Registered: 9-12-2017
Location: Los Angeles, California
Member Is Offline

Mood: w00h00!

[*] posted on 10-3-2017 at 02:16 AM


Quote: Originally posted by Scarlet  
Thank you for helping.
Hopefully Xian will see this and add it to 1.9.12.5, although I haven't seen him here since the 19th... I'm hoping he's okay :)


I'm ok, thanks! Just handling a family emergency and I got sick in the process. I'll be back soon.
View user's profile View All Posts By User
lottos
Administrator
********




Posts: 357
Registered: 6-3-2002
Location: Competitions Australia: https://www.lottos.com.au/
Member Is Offline

Mood: pass me a TimTam

[*] posted on 10-3-2017 at 11:06 AM


Quote: Originally posted by Xian  
Quote: Originally posted by Scarlet  
Thank you for helping.
Hopefully Xian will see this and add it to 1.9.12.5, although I haven't seen him here since the 19th... I'm hoping he's okay :)


I'm ok, thanks! Just handling a family emergency and I got sick in the process. I'll be back soon.


Take care of yourself Xian...




Largest list of competitions online!
View user's profile Visit user's homepage View All Posts By User
Daniel Gouveia
XMB International Support
*********


Avatar


Posts: 64
Registered: 4-10-2007
Location: Portugal, Braga
Member Is Offline

Mood: |Catch Me If You Can|

[*] posted on 10-28-2017 at 11:21 PM


Fixed:
PHP7+ | MySQLi
Attachment
Captcha
Poll
Stats
Today
Https Avatar (by Xian & Scarlet)
Security pacth and some bugs.

Test it :)

Attachment: XMB-1.9.11.13.zip (1.3MB)
This file has been downloaded 16 times






You Never Walk Alone
View user's profile View All Posts By User
lottos
Administrator
********




Posts: 357
Registered: 6-3-2002
Location: Competitions Australia: https://www.lottos.com.au/
Member Is Offline

Mood: pass me a TimTam

[*] posted on 10-29-2017 at 02:44 AM


Quote: Originally posted by Daniel Gouveia  
Fixed:
PHP7+ | MySQLi
Attachment
Captcha
Poll
Stats
Today
Https Avatar (by Xian & Scarlet)
Security pacth and some bugs.

Test it :)


You are awesome! Even dot folders functionality has been added!




Largest list of competitions online!
View user's profile Visit user's homepage View All Posts By User
lottos
Administrator
********




Posts: 357
Registered: 6-3-2002
Location: Competitions Australia: https://www.lottos.com.au/
Member Is Offline

Mood: pass me a TimTam

[*] posted on 10-29-2017 at 04:39 AM


Tested with php 7.2 alpha

Minor issues:

update year in text in installer:
The XMB Group © 2001-2011

remove text from installer:
Sponsored by iEntry

footer template shows 2012




Largest list of competitions online!
View user's profile Visit user's homepage View All Posts By User
Daniel Gouveia
XMB International Support
*********


Avatar


Posts: 64
Registered: 4-10-2007
Location: Portugal, Braga
Member Is Offline

Mood: |Catch Me If You Can|

[*] posted on 10-30-2017 at 01:41 PM


Quote: Originally posted by lottos  
Tested with php 7.2 alpha

Minor issues:

update year in text in installer:
The XMB Group © 2001-2011

remove text from installer:
Sponsored by iEntry

footer template shows 2012


Fixed:
» Installer
» Insert Raw SQL
» Analyze Tables
» Check Tables
» Optimize Tables
» Repair Tables


Upgrade add.



Attachment: XMB-1.9.11.14.zip (1.3MB)
This file has been downloaded 30 times






You Never Walk Alone
View user's profile View All Posts By User
 Pages:  1  2  

  Go To Top

Powered by XMB 1.9.11 (Debug Mode)
Forum Script Software by XMB © 2001-2019 The XMB Group
[Queries: 16] [PHP: 44.0% - SQL: 56.0%]
Funded with thanks to competitions website.