Yes! I bet you so! :3

I removed the word BETA from the version string and left the BETA that was in the $beta string, so it isn't duplicated anymore.

Anyway feel free to push the installer stuff and make some changes to detect PHP 5.5 or later and auto-select mysqli... Then I think we can call it a proper release since nothing has broken on my end so far.

Two more things to get fixed:

1. Wrong offset while rendering polls(shows only first letter of every option)
   
2. Wrong number formatting in stats page(works,but throws ugly warnings)
   

P.S. Tested in PHP version 7.1.9 & 7.1.8

Not getting the poll error on 7.0, although you're using 7.1 so uh... yeah, we need to fix that I guess.

Quote: Originally posted by Scarlet

Not getting the poll error on 7.0, although you're using 7.1 so uh... yeah, we need to fix that I guess.

Indeed. Just tested using 7.0.23, works bugless. I think they might have changed something with 7.1.x branch.

Yeah, best to be safe and make sure everything is compatible though. I probably won't adopt PHP 7.1 until it becomes a bit more mature, and once XMB is patched to work with it.

Have you looked into the problem so far?

Quote: Originally posted by Scarlet

Yeah, best to be safe and make sure everything is compatible though. I probably won't adopt PHP 7.1 until it becomes a bit more mature, and once XMB is patched to work with it. Have you looked into the problem so far?

Not yet, I was busy with daily chores and other stuff.
In regards of PHP 7.1.x, it's stable enough, because it's not some beta release or anything. It most likely has some sort of adjustment on how offsets are being handled, most likely it requires a different syntax in order to make it function properly.

I can probably fix it for myself, I just let the forum know that there's an issue that could be stumbled upon.

I'm in preparation of fully porting XMB to MySQLi(prepared statements) while at the same time getting rid of old MySQL(supporting both is not an option for me). Cause why have two things that serves the same purpose and especially when one of them is ****tier at doing it? XMB always meant to be lightweight, hehehehe

Ah, alright.

I'll consider upgrading to PHP 7.1 when the XMB bugs are ironed out and it has been made compatible. But yeah, it probably does, hence why that.

And yeah, hopefully someone can see this and respond to this so you don't have to do the hard work

As for XMB to MySQLi, I agree. XMB is supposed to be a lightweight solution, so why keep the deprecated/removed system?

I did further testing. If the poll already has your vote and tries to display the result, it completely blows up the whole script ending it with fatal error.

This is the reason for it:
As of PHP 7.1.0, applying the empty index operator on a string throws a fatal error. Formerly, the string was silently converted to an array.(PHP Notes)


Prior to PHP 7.1 this was valid:

Code:

$str = 'hello'; $str[] = 'good-bye'; //returns an array with two elements ['hello', 'good-bye'];

But PHP 7.1 would just return an error: Uncaught Error: [] operator not supported for strings, which is exact response I'm getting.

Code:

<?php $hellomsg='Hey there!!!'; $str=''; $str['hello'] = $hellomsg; var_dump($str['hello']); Response: Warning: Illegal string offset 'hello' in C:\UwAmp\www\3\test.php on line 7 Warning: Illegal string offset 'hello' in C:\UwAmp\www\3\test.php on line 10 string(1) "H"

As you may see it also returns the first letter of the string $str['hello'], just like the poll options in XMB. I'm 100% positive that that's the problem we encountering in here.

Fix for both examples(cast first occurrence that is defined as string to an array):

Code:

$str = (array)$str; // lets cast a string to an array

Now it's really up to just finding which lines & strings to tune up in XMB

Thanks for looking into the problem. What pages are affected by this?

Quote: Originally posted by Scarlet

Thanks for looking into the problem. What pages are affected by this?

It's all in the screenshots I've attached, but since you asked: viewthread.php(compatibility issues mentioned in my last post) & stats.php(formatting errors)

Either way, I have already patched those mentioned files & everything runs smoothly on 7.1.x(so far).

Thank you for helping.
Hopefully Xian will see this and add it to 1.9.12.5, although I haven't seen him here since the 19th... I'm hoping he's okay

Quote: Originally posted by Scarlet

Thank you for helping. Hopefully Xian will see this and add it to 1.9.12.5, although I haven't seen him here since the 19th... I'm hoping he's okay

Yeah, that 's quite normal. People are being busy with life and so on. Btw, he's not the only one that can access and upload changes to Sourceforge, so his absence not big of the deal.

Quote: Originally posted by Jenny Lee

Btw, he's not the only one that can access and upload changes to Sourceforge, so his absence not big of the deal.

I've put the issue into the bugtracker, thanks.

How would I go about committing to the repository? I don't know SourceForge too well, only GitHub.

Quote: Originally posted by Scarlet

Thank you for helping. Hopefully Xian will see this and add it to 1.9.12.5, although I haven't seen him here since the 19th... I'm hoping he's okay

I'm ok, thanks! Just handling a family emergency and I got sick in the process. I'll be back soon.

Quote: Originally posted by Xian

Quote: Originally posted by Scarlet   Thank you for helping. Hopefully Xian will see this and add it to 1.9.12.5, although I haven't seen him here since the 19th... I'm hoping he's okay I'm ok, thanks! Just handling a family emergency and I got sick in the process. I'll be back soon.

Take care of yourself Xian...

Fixed:
PHP7+ | MySQLi
Attachment
Captcha
Poll
Stats
Today
Https Avatar (by Xian & Scarlet)
Security pacth and some bugs.

Test it

Attachment: XMB-1.9.11.13.zip (1.3MB)
This file has been downloaded 56 times

Quote: Originally posted by Daniel Gouveia

Fixed: PHP7+ | MySQLi Attachment Captcha Poll Stats Today Https Avatar (by Xian & Scarlet) Security pacth and some bugs. Test it

You are awesome! Even dot folders functionality has been added!

Tested with php 7.2 alpha

Minor issues:

update year in text in installer:
The XMB Group © 2001-2011

remove text from installer:
Sponsored by iEntry

footer template shows 2012

Quote: Originally posted by lottos

Tested with php 7.2 alpha Minor issues: update year in text in installer: The XMB Group © 2001-2011 remove text from installer: Sponsored by iEntry footer template shows 2012

Fixed:
» Installer
» Insert Raw SQL
» Analyze Tables
» Check Tables
» Optimize Tables
» Repair Tables


Upgrade add.



Attachment: XMB-1.9.11.14.zip (1.3MB)
This file has been downloaded 66 times