XMB Forum Software

Smilies Defect?

miqrogroove - 8-28-2025 at 10:15 AM

There is something unexpected here:

ini_set('error_log', 'error_log');

Why is ...

Code:
')


... being processed as a smilie with the new database message encoding?

And why does an extra semicolon appear after the smilie?

flushedpancake - 8-28-2025 at 06:51 PM

') is being turned into ') it seems?

the smiley filter doesn't check things like spaces and it runs after everything else is processed.

hence, wink face with an extra semicolon after because your message already had a semicolon in it

---

what I don't get is why it explicitly seems to trigger with a single escape and a closing bracket. ending in a semicolon is not exclusive to &pos;.

miqrogroove - 8-28-2025 at 10:00 PM

Oh, you're right. The message was:

Code:
');


Probably I mismatched the smilie input or forgot to update it somewhere along the line. It's in the bug tracker now for further study.

miqrogroove - 8-28-2025 at 10:22 PM

Quote: Originally posted by flushedpancake  
what I don't get is why it explicitly seems to trigger with a single escape and a closing bracket. ending in a semicolon is not exclusive to &pos;.


This part is correct. One of the default smilie codes is set up like emoticon substitution...

Code:
;)


We just need to make sure encoded and non-encoded strings aren't getting mixed up internally.

miqrogroove - 8-28-2025 at 10:47 PM

Need to test on 1.9.12 what happens if a non-latin-1 character is followed by a ). Then we will know if this is a new bug or an old bug made worse by apostrophe encoding.