[Resolved] XMB 1.9.12 BETA

Apparently there is some sort of formatting error in function phpShorthandValue. Server using PHP 7.1.8, also tested on 5.6(no errors were present).

Quote: Originally posted by lottos

Not unique to XMB 1.9.12 BETA

Yeah, it's also present 1.9.11. Either way, since it's a notice, you could probably get rid of displaying the error via ini_settings, but that doesn't really solve the problem. I'd like to have all warnings on.

Nice thing linking to my thread I made earlier

Quote: Originally posted by lottos

Not unique to XMB 1.9.12 BETA but may as well link to it: http://forums.xmbforum2.com/viewthread.php?tid=776998

Could you try this:

1. Open ./include/functions.inc.php

2. Find:

function phpShorthandValue($ininame) {
$rawstring = trim(ini_get($ininame));
$rchr = strtoupper(substr($rawstring, -1));
switch ($rchr) {
case 'G':
$rawstring *= 1073741824;
break;
case 'M':
$rawstring *= 1048576;
break;
case 'K':
$rawstring *= 1024;
break;
default:
$rawstring = intval($rawstring);
break;
}
return $rawstring;
}

3. Change to:

/*
function phpShorthandValue($ininame) {
$rawstring = trim(ini_get($ininame));
$rchr = strtoupper(substr($rawstring, -1));
switch ($rchr) {
case 'G':
$rawstring *= 1073741824;
break;
case 'M':
$rawstring *= 1048576;
break;
case 'K':
$rawstring *= 1024;
break;
default:
$rawstring = intval($rawstring);
break;
}
return $rawstring;
}
*/

4. Add below that:

function phpShorthandValue($ininame) {
$rawstring = trim(ini_get($ininame));
if (is_string($rawstring)) {
switch (substr($rawstring, -1)) {
case 'M': case 'm': return (int) $rawstring * 1048576;
case 'K': case 'k': return (int) $rawstring * 1024;
case 'G': case 'g': return (int) $rawstring * 1073741824;
}
}
return (int) $rawstring;
}

5. Save file.

6. Test

Please let me know how it goes.

That's how I fixed it for myself, yet I'm not sure what this function is used for in order to properly test it, but value is being returned the same as in non edited version of PHP 5.

function phpShorthandValue($ininame) {
$rawstring = trim(ini_get($ininame));
$rchr = strtoupper(substr($rawstring, -1));
$rawstring = (integer)$rawstring;
switch ($rchr) {
case 'G':
$rawstring *= 1073741824;
break;
case 'M':
$rawstring *= 1048576;
break;
case 'K':
$rawstring *= 1024;
break;
default:
$rawstring = intval($rawstring);
break;
}
return $rawstring;
}

Either way, thanks for your code too. I might double check the output of both fixes, but if responses are identical I think my way is a bit less messy as far as code goes.

Nice, now I can actually test it out. Thanks for the pointers.

Alright, I wrote a little script to test that mess. As suspected, original throws an error while other two works just fine. I have attached the script, so you could test it for yourself.
Use $_GET['size'] for testing custom values, but this is optional.


Attachment: test.php (2kB)
This file has been downloaded 629 times

Since Jenny says her way is a cleaner piece of code I'll probably fix that with my own board before I finally upgrade the server to PHP 7. Just a quick question, how do I upgrade from 5.6 to 7.0 on Debian 8 Jessie? I don't want to break anything if I try reading tutorials and such and I know I can trust the XMB Community.

Quote: Originally posted by Scarlet

Since Jenny says her way is a cleaner piece of code I'll probably fix that with my own board before I finally upgrade the server to PHP 7.

I don't recommend using those fixes, because none of those those 3 functions(including original) were convenient enough. If user uses two letter format (MB, KB, GB) instead of one( M,K,G) current functions just bails out or shows complete gibberish.

Use the one from fix.php attached to this post

Attachment: fix.php (662B)
This file has been downloaded 579 times

In regards of php upgrading, you most likely need to use a package manager.
Something like apt-get install php7.1 should do.
P.S. If it does nothing you need to add repositories manually, I think.

Quote: Originally posted by lottos

Xian, do you think we should have a number system for the beta? Just in case people who aren't following this topic download from sourceforge may think the beta is the same, whereas it's already changed I think 3 times? eg: 1.9.12.2

LOL! You're right. Let's number them like that. I will update them when I get home.

Quote: Originally posted by lottos

A few pre-existing pre .12 beta bugs listed here: https://bugs.xmbforum2.com/my_view_page.php

Thanks for the link! I will see what I can do with some of them.